Asana | Fix events stream #1304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
According to airbytehq/airbyte#31114 and airbytehq/airbyte#31114, those streams will throw errors if the account doesn't pay for an Asana's paid plan.
The problem with the events' stream is the different pagination style that demands the first request to return a 'Precondition Failed' failed error (412).
About the Events stream, it is broken because of pagination, so it is not related to the paid account issue. I tested this flow with both paid and free accounts, the error is the sync token. I also added a condition in the
next_page_tokenmethod to stop reading if the API returnshas_moreas false.Pagination for HTTP API connectors
Asana API Reference:
This change is